Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape user-controlled variables in GA workflow #7415

Merged
merged 1 commit into from
May 12, 2024
Merged

Escape user-controlled variables in GA workflow #7415

merged 1 commit into from
May 12, 2024

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented May 10, 2024

/cc @lagru

Should test that it works.

@lagru lagru added the 🤖 type: Infrastructure CI, packaging, tools and automation label May 12, 2024
lagru
lagru approved these changes May 12, 2024
View reviewed changes
Copy link
Member

@lagru lagru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

How do you suppose we should test this right now? Do you want to try a malicious branch name?

I'm not sure when we last ran this workflow. We should probably disable it until we intend to fix and maintain it again.

@lagru
Copy link
Member

lagru commented May 12, 2024

For reference: here's the relevant section in GitHub's docs on how to mitigate this.

@lagru lagru merged commit f5f4b0c into scikit-image:main May 12, 2024
23 of 24 checks passed
@stefanv stefanv added this to the 0.24 milestone May 12, 2024
@lagru lagru mentioned this pull request May 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lagru lagru lagru approved these changes

Assignees
No one assigned
Labels
🤖 type: Infrastructure CI, packaging, tools and automation
Projects
None yet
Milestone
0.24
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanv @lagru