Fix for sklearn-pandas-out and refit #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
py3.7 fails because I guess the version of sklearn that adds pandas-output doesn't support 3.7? I could decorate the test to skip it in 3.7, but am open to better fixes. |
bmreiniger
changed the title
|
great work Ben. Thanks for fixing this! |
PaulWestenthanner
merged commit 11fbba6
into
scikit-learn-contrib:master
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437
Proposed Changes
Resets
feature_names_out_before applyingtransform(in case the latter uses the former, as when sklearn is set to pandas-output).