Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT make imbalanced-learn compatible with scikit-learn 1.+ #946

Merged
merged 12 commits into from
Dec 2, 2022

Conversation

glemaitre
Copy link
Member

Update code to make sure that scikit-learn works with version 1.0+

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Base: 97.19% // Head: 92.61% // Decreases project coverage by -4.58% ⚠️

Coverage data is based on head (c4e8b75) compared to base (6176807).
Patch coverage: 73.63% of modified lines in pull request are covered.

❗ Current head c4e8b75 differs from pull request most recent head 7beb41a. Consider uploading reports for the commit 7beb41a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #946      +/-   ##
==========================================
- Coverage   97.19%   92.61%   -4.59%     
==========================================
  Files          97       94       -3     
  Lines        6348     6361      +13     
  Branches      711      886     +175     
==========================================
- Hits         6170     5891     -279     
- Misses        106      398     +292     
  Partials       72       72              
Impacted Files Coverage Δ
imblearn/combine/_smote_enn.py 100.00% <ø> (ø)
imblearn/combine/_smote_tomek.py 100.00% <ø> (ø)
imblearn/metrics/_classification.py 92.12% <ø> (ø)
imblearn/over_sampling/_adasyn.py 88.05% <ø> (ø)
imblearn/over_sampling/_random_over_sampler.py 100.00% <ø> (ø)
imblearn/over_sampling/_smote/base.py 99.01% <ø> (ø)
imblearn/over_sampling/_smote/filter.py 88.33% <ø> (ø)
imblearn/over_sampling/base.py 100.00% <ø> (ø)
imblearn/pipeline.py 93.47% <ø> (-1.09%) ⬇️
...mpling/_prototype_generation/_cluster_centroids.py 100.00% <ø> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hayesall
Copy link
Member

hayesall commented Dec 2, 2022

#936 and #938 should resolve the build issues. Should we merge them in first?

@glemaitre
Copy link
Member Author

Thanks for pointing that out. I will delay the mode deprecating for afterwards. I want first to fix all failures for 1.2 and check what we need to do to be compatible with 1.1 and 1.0. Then, I will modify the CI and finally make a new pass on all remaining deprecations.

@glemaitre glemaitre changed the title MAINT fix BalancedBaggingClassifier MAINT make imbalanced-learn compatible with scikit-learn 1.0+ Dec 2, 2022
@glemaitre glemaitre changed the title MAINT make imbalanced-learn compatible with scikit-learn 1.0+ MAINT make imbalanced-learn compatible with scikit-learn 1.+ Dec 2, 2022
@glemaitre glemaitre merged commit 2779327 into scikit-learn-contrib:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants