Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT add parameter validation framework #955

Merged
merged 18 commits into from
Dec 4, 2022

Conversation

glemaitre
Copy link
Member

Adding support for automatic parameters validation

@codecov
Copy link

codecov bot commented Dec 4, 2022

Codecov Report

Base: 96.27% // Head: 96.08% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (82e6790) compared to base (063da64).
Patch coverage: 96.53% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   96.27%   96.08%   -0.19%     
==========================================
  Files          97       99       +2     
  Lines        6283     6879     +596     
  Branches      875      992     +117     
==========================================
+ Hits         6049     6610     +561     
- Misses        148      166      +18     
- Partials       86      103      +17     
Impacted Files Coverage Δ
imblearn/combine/tests/test_smote_enn.py 100.00% <ø> (ø)
imblearn/combine/tests/test_smote_tomek.py 100.00% <ø> (ø)
imblearn/ensemble/tests/test_bagging.py 98.23% <ø> (-0.06%) ⬇️
imblearn/ensemble/tests/test_easy_ensemble.py 96.42% <ø> (-0.19%) ⬇️
imblearn/ensemble/tests/test_forest.py 96.29% <ø> (-0.17%) ⬇️
imblearn/ensemble/tests/test_weight_boosting.py 93.22% <ø> (-0.53%) ⬇️
...ver_sampling/_smote/tests/test_borderline_smote.py 100.00% <ø> (ø)
...rn/over_sampling/_smote/tests/test_kmeans_smote.py 100.00% <ø> (ø)
imblearn/over_sampling/tests/test_adasyn.py 100.00% <ø> (ø)
..._selection/tests/test_edited_nearest_neighbours.py 100.00% <ø> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glemaitre glemaitre merged commit a84b63f into scikit-learn-contrib:master Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant