Bugs and performance issues related to PCov-ized sample selection methods #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luthaf
reviewed
Oct 22, 2021
rosecers
force-pushed
the
bugfix/pcovr_orthogonalize
branch
3 times, most recently
from
4c8db39 to
bf19d9e
Compare
Loooots of printf debug statements. Also changed regression to lstsq which makes the y orthogonalization 10x faster
rosecers
force-pushed
the
bugfix/pcovr_orthogonalize
branch
from
bf19d9e to
740b00e
Compare
rosecers
approved these changes
Oct 22, 2021
|
Should we do a 0.1.1 release with this bugfix included? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was started noting a bug in the orthogonalization of targets in PCov-CUR, and evolved to also tackle some performance issues, and a nasty bug where all sample-space PCov selection methods would give nonsense when using a 1D array as the target vector y. Urgent merge.