Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH implement gradient and allow y_i = 0 in Poisson datafit #253

Merged
merged 3 commits into from
May 31, 2024

Conversation

mathurinm
Copy link
Collaborator

This fixes some of the issues in #251 and can be merged while we conitnue to investigate the particular, data-related problem encountered in #252

@mathurinm mathurinm changed the title Poisson: implement gradient and allow y_i = 0 ENH implement gradient and allow y_i = 0 in Poisson datafit May 31, 2024
@Badr-MOUFAD Badr-MOUFAD changed the title ENH implement gradient and allow y_i = 0 in Poisson datafit ENH implement gradient and allow y_i = 0 in Poisson datafit May 31, 2024
Copy link
Collaborator

@Badr-MOUFAD Badr-MOUFAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mathurinm mathurinm merged commit 7ae11ea into scikit-learn-contrib:main May 31, 2024
4 checks passed
@mathurinm mathurinm deleted the poisson_fixes branch May 31, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants