Skip to content

add developer API post #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 6, 2025
Merged

add developer API post #198

merged 4 commits into from
Jan 6, 2025

Conversation

adrinjalali
Copy link
Member

We can also add a link to this from our release highlights.

@jeremiedbb
Copy link
Member

We can also add a link to this from our release highlights.

Yes that was the goal IIRC.

Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on my side. Now that we released on PyPI, I would fine publishing the blog post and advertise it on the social media to get potential feedbacks.

Copy link
Member

@jeremiedbb jeremiedbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if Guillaume's message on discord https://discord.com/channels/731163543038197871/1046822941586898974/1316511187005079553 doesn't receive negative feedback.

cycle warning.

In the past few releases, we've slowly introduced more functionalities under this
umbrella. `__sklearn_clone__` and `__sklearn_is_fitted__` are two examples.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an easy way to tell what is part of this developer API? If yes we could mention it here. If no, we could create it at some point later (not needed for this blog post)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah been thinking about that too

@betatim
Copy link
Member

betatim commented Dec 16, 2024

Left a few style comments, otherwise this looks good to me. Useful information!

@betatim
Copy link
Member

betatim commented Jan 6, 2025

@adrinjalali should we merge this or wait for more people to give a 👍 ?

@adrinjalali
Copy link
Member Author

I think we can merge

@betatim betatim merged commit 5a9aa41 into scikit-learn:main Jan 6, 2025
@betatim
Copy link
Member

betatim commented Jan 6, 2025

Done! Thanks for writing this up as well as doing the actual work

@jeremiedbb
Copy link
Member

Thanks ! Let's link it in the 1.6 release highlights

@adrinjalali adrinjalali deleted the dev-api branch January 6, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants