-
Notifications
You must be signed in to change notification settings - Fork 24
add developer API post #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Yes that was the goal IIRC. |
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on my side. Now that we released on PyPI, I would fine publishing the blog post and advertise it on the social media to get potential feedbacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if Guillaume's message on discord https://discord.com/channels/731163543038197871/1046822941586898974/1316511187005079553 doesn't receive negative feedback.
cycle warning. | ||
|
||
In the past few releases, we've slowly introduced more functionalities under this | ||
umbrella. `__sklearn_clone__` and `__sklearn_is_fitted__` are two examples. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an easy way to tell what is part of this developer API? If yes we could mention it here. If no, we could create it at some point later (not needed for this blog post)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah been thinking about that too
Left a few style comments, otherwise this looks good to me. Useful information! |
@adrinjalali should we merge this or wait for more people to give a 👍 ? |
I think we can merge |
Done! Thanks for writing this up as well as doing the actual work |
Thanks ! Let's link it in the 1.6 release highlights |
We can also add a link to this from our release highlights.