Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents simplex assembly in last dimension #132

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

ulupo
Copy link
Contributor

@ulupo ulupo commented Sep 19, 2021

This is just a copy of reds-heig/ripser@65225bf which has already been submitted as a PR to the "upstream" ripser repository as Ripser/ripser#37.

See Figure 6 in our paper illustrating the impact on memory.

@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #132 (f831bce) into master (9d9b7c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files           3        3           
  Lines         154      154           
  Branches       26       26           
=======================================
  Hits          146      146           
  Misses          7        7           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d9b7c4...f831bce. Read the comment docs.

@ctralie
Copy link
Member

ctralie commented Sep 19, 2021

Thank you!!

@ctralie ctralie merged commit 2a173d0 into scikit-tda:master Sep 19, 2021
@ulupo
Copy link
Contributor Author

ulupo commented Sep 19, 2021

Thanks @ctralie! I just noticed some of the CI failed. It does not look to me like it is related to the changes introduced here, but I'm pointing it out just in case.

@ulupo ulupo deleted the prevent_simplex_assembly_last_dim branch September 19, 2021 12:23
@ctralie
Copy link
Member

ctralie commented Sep 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants