Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix module not found #172

Merged
merged 5 commits into from
Jul 12, 2024
Merged

Conversation

catanzaromj
Copy link
Contributor

Updating the build system in v0.6.9 did not include the python ripser module due to incorrect package discovery. This PR converts the package to a src style to make this easier to maintain moving forward, as well as actually getting the python package discovered correctly.

@catanzaromj
Copy link
Contributor Author

It would be nice to add wheel tests directly so that this can be avoided in the future.

@catanzaromj catanzaromj linked an issue Jul 12, 2024 that may be closed by this pull request
@catanzaromj catanzaromj self-assigned this Jul 12, 2024
@catanzaromj catanzaromj merged commit 59610da into scikit-tda:master Jul 12, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'ripser'
1 participant