-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use tractoflow subworkflow #2
Open
AlexVCaron
wants to merge
29
commits into
scilus:dev
Choose a base branch
from
AlexVCaron:feat/tractoflow_swkf
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I like it! The main workflow file is super clean. It is a bit hard to review due to the 380 files changed, so I don't have any specific changes, but more questions:
Great job again! 💯 |
Merged
2d6e01f
to
976b76d
Compare
976b76d
to
a93757e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the current implementation to use the
tractoflow
subworkflow from nf-neuro. I had to do some fixes in some modules and subworkflows to make things work. I have PRs incomming to nf-neuro to propagate those fixes.Tractoflow profiles (ABS, GPU, etc.) not yet implemented.
The current implementation comes with 2 tests profiles :
Currently, you need to have the
mni_152_sym_09c
template (or the one of your choice) downloaded locally (e.g. in the workdir where you'll run the tests) and supplied using--template_t1
. We should think about adding a module to download atlases when they are not supplied directly or unavailable because the pipeline is not run inside of docker.Here is an example command to run a test :
nextflow run <nf-tractoflow directory> -profile docker,test --outdir <workdir>/results/ --template_t1 <workdir>/mni_152_sym_09c/t1 -resume
I intend to implement more tests, but we should discuss which ones we want so I don't do too much.