Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use tractoflow subworkflow #2

Open
wants to merge 29 commits into
base: dev
Choose a base branch
from

Conversation

AlexVCaron
Copy link
Collaborator

@AlexVCaron AlexVCaron commented Feb 17, 2025

Switch the current implementation to use the tractoflow subworkflow from nf-neuro. I had to do some fixes in some modules and subworkflows to make things work. I have PRs incomming to nf-neuro to propagate those fixes.

Tractoflow profiles (ABS, GPU, etc.) not yet implemented.

The current implementation comes with 2 tests profiles :

  • test : DWI + rev EPI + T1w
  • test_full : DWI + rev DWI + T1w

Currently, you need to have the mni_152_sym_09c template (or the one of your choice) downloaded locally (e.g. in the workdir where you'll run the tests) and supplied using --template_t1. We should think about adding a module to download atlases when they are not supplied directly or unavailable because the pipeline is not run inside of docker.

Here is an example command to run a test :

nextflow run <nf-tractoflow directory> -profile docker,test --outdir <workdir>/results/ --template_t1 <workdir>/mni_152_sym_09c/t1 -resume

I intend to implement more tests, but we should discuss which ones we want so I don't do too much.

@gagnonanthony
Copy link

I like it! The main workflow file is super clean. It is a bit hard to review due to the 380 files changed, so I don't have any specific changes, but more questions:

  1. I saw that the currently supported input format is the samplesheet? Do we want to start like this first, then move to BIDS or something else?
  2. The test cases currently are not using nf-test but are directly calling the pipeline. I know this is how the CI actions are set up by default, but should we switch to nf-test? This could be interesting to perform some assertions after each test runs.

Great job again! 💯

@AlexVCaron AlexVCaron mentioned this pull request Mar 3, 2025
@AlexVCaron AlexVCaron force-pushed the feat/tractoflow_swkf branch from 2d6e01f to 976b76d Compare March 14, 2025 19:37
@AlexVCaron AlexVCaron changed the base branch from master to dev March 14, 2025 19:39
@AlexVCaron AlexVCaron force-pushed the feat/tractoflow_swkf branch from 976b76d to a93757e Compare March 14, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants