Change Crop Volume BBOX for a json

[AlexVCaron]

Quick description

Pickles are path bound and unsafe. A json file is way easier to use and doesn't pose code injection problems.

...

Type of change

Check the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

pytest scripts/tests/test_colume_crop.py

Checklist

• My code follows the style guidelines of this project (run autopep8)
• I added relevant citations to scripts, modules and functions docstrings and descriptions
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I moved all functions from the script file (except the argparser and main) to scilpy modules
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pep8speaks]

Hello @AlexVCaron, Thank you for updating !

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-12-12 19:35:21 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (e256482) to head (59d7b7f).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1096      +/-   ##
==========================================
+ Coverage   69.46%   69.47%   +0.01%     
==========================================
  Files         447      447              
  Lines       24052    24060       +8     
  Branches     3291     3291              
==========================================
+ Hits        16708    16716       +8     
  Misses       5946     5946              
  Partials     1398     1398              

Components	Coverage Δ
Scripts	70.26% <100.00%> (-0.01%)	⬇️
Library	68.42% <100.00%> (+0.02%)	⬆️

[EmmaRenauld]

Thanks!

But should we add an argument like --use_deprecated_pickle in case someone wants to use one that was already computed, with some warning that eventually we will delete the code for pickles, or not necessary? @arnaudbore

If not, LGTM