Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn-tools changes order of integrity field, moves it to tail #8

Closed
kompot opened this issue Oct 11, 2018 · 4 comments
Closed

Yarn-tools changes order of integrity field, moves it to tail #8

kompot opened this issue Oct 11, 2018 · 4 comments

Comments

@kompot
Copy link

kompot commented Oct 11, 2018

Hi,
with the recent addition of integrity field
yarnpkg/yarn#5042
yarn-tools started to alter valid yarn.lock and it produce diffs with no real change.

Before running it is

"@types/react-virtualized@^9.7.4":
  version "9.18.5"
  resolved "https://registry.yarnpkg.com/@types/react-virtualized/-/react-virtualized-9.18.5.tgz#8c6b4e739e2fc4a601dd3e5e114dd0deeba56cc7"
  integrity sha512-ptqFDzemkXGMf7ylch/bCV+XTDvVjD9dRymzcjOPIxg8Hqt/uesOye10GXItFbsxJx9VZeJBYrR8FFTauu+hHg==
  dependencies:
    "@types/prop-types" "*"
    "@types/react" "*"

and after yarn-tools it is

"@types/react-virtualized@^9.7.4":
  version "9.18.5"
  resolved "https://registry.yarnpkg.com/@types/react-virtualized/-/react-virtualized-9.18.5.tgz#8c6b4e739e2fc4a601dd3e5e114dd0deeba56cc7"
  dependencies:
    "@types/prop-types" "*"
    "@types/react" "*"
  integrity sha512-ptqFDzemkXGMf7ylch/bCV+XTDvVjD9dRymzcjOPIxg8Hqt/uesOye10GXItFbsxJx9VZeJBYrR8FFTauu+hHg==
@lukebatchelor
Copy link
Contributor

lukebatchelor commented Oct 12, 2018

Related: yarnpkg/yarn#6364

It's fixed in @yarnpkg/lockfile 1.1. I'll try to update it now

@Bnaya
Copy link

Bnaya commented Oct 28, 2018

friendly ping @lukebatchelor :)

@lukebatchelor
Copy link
Contributor

lukebatchelor commented Oct 29, 2018

The PR is up, just waiting on a merge.

CC: @scinos

scinos added a commit that referenced this issue Oct 29, 2018
…ssion

Fixes #8 - yarn-tools changes order or integrity field
@scinos
Copy link
Owner

scinos commented Oct 29, 2018

Fixed in 1.0-dev. I'll close this issue once the patch is released as part of version 1.0

@scinos scinos closed this as completed in b61393e Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants