Skip to content

Commit

Permalink
Update corresponding to review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
mlegner committed Oct 21, 2019
1 parent 057c213 commit 1d17535
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 9 deletions.
15 changes: 8 additions & 7 deletions doc/BeaconService.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,18 @@ PCBs to propagate or register are selected according to an AS-level policy.
Additionally, the BS is also responsible for determining the state of all interfaces in the AS. For this,
each BS pings the neighboring AS' BS over each interface. If a ping isn't received for a certain
amount of time on an interface, the BS assumes the interface is down and sends a revocation to
all border routers (BRs) in the AS, to the local [path server (PS)](/doc/PathService.md), and to all core PSes.
all border routers (BRs) in the AS, to the local [path server (PS)](PathService.md), and to all core
PSes.

## General Structure

The BS is structured similar to the existing go infra services.
It reuses the existing building blocks for go services:

* [go/lib/env](/go/lib/env): Is used for configuration and setup of the service.
* [go/lib/infra/modules/trust](/go/lib/infra/modules/trust): Is used for TRCs and other crypto material.
* [go/lib/infra](/go/lib/infra): Is used for the messenger to send and receive messages.
* [go/lib/periodic](go/lib/periodic): Is used for periodic tasks.
* [go/lib/env](../go/lib/env): Is used for configuration and setup of the service.
* [go/lib/infra/modules/trust](../go/lib/infra/modules/trust): Is used for TRCs and other crypto material.
* [go/lib/infra](../go/lib/infra): Is used for the messenger to send and receive messages.
* [go/lib/periodic](../go/lib/periodic): Is used for periodic tasks.
* etc. ...

The main parts of the BS are
Expand All @@ -30,7 +31,7 @@ The main parts of the BS are
* **beacon storage**.

Each part is described in a separate chapter below. These parts can be grouped together into two
subjects. *Beaconing* and *interface state keeping*.
subjects: *beaconing* and *interface state keeping*.

The beaconing part takes care of handling beacons and registering them.
The following diagram shows an overview of the components related to beaconing and their dependency
Expand Down Expand Up @@ -85,7 +86,7 @@ type BeaconStore interface {

### Policy

A [policy](/doc/PathPolicy.md) contains the parameters for the selection heuristic and the filters for inserting the
A policy contains the parameters for the selection heuristic and the filters for inserting the
beacon into the BeaconDB. BSes have multiple policies for different purposes. Beacons that
are filtered by all policies are not added to the BeaconDB.

Expand Down
6 changes: 4 additions & 2 deletions doc/DRKeyInfra.md
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,9 @@ SrcHost []byte
DstHost []byte
```

### First-Level Key Exchange
### Key Exchange

#### First Level

For the first-level key exchange between CS, we can use SignedCtrlPld. Thus,
the request ID, timestamp, signature, certificate and TRC version do not need
Expand All @@ -467,7 +469,7 @@ DRKeyLvl1Rep {
}
```

### Second-Level Key Exchange
#### Second Level

The second level key response will also be transmitted with SignedCtrlPld.

Expand Down

0 comments on commit 1d17535

Please sign in to comment.