Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PS: Non-core PS handles ISD-local AS-wildcard query wrong #2281

Closed
lukedirtwalker opened this issue Dec 28, 2018 · 0 comments
Closed

PS: Non-core PS handles ISD-local AS-wildcard query wrong #2281

lukedirtwalker opened this issue Dec 28, 2018 · 0 comments
Assignees
@lukedirtwalker

Comments

@lukedirtwalker
Copy link
Collaborator

The non-core Go-PS will try to fetch core segments if the destination is the ISD-local wildcard (e.g. 1-0). And since all replies are empty it will return an empty reply.

Instead we should just return the up segments.
@lukedirtwalker lukedirtwalker self-assigned this Dec 28, 2018
@lukedirtwalker lukedirtwalker changed the title PS: Non-core PS handles ISD-local wildcard wrong PS: Non-core PS handles ISD-local AS-wildcard query wrong Dec 28, 2018
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Dec 28, 2018
@lukedirtwalker
PS: Handle ISD-local AS-wildcard seg requests
e8daae2 
Fixes scionproto#2281
@lukedirtwalker lukedirtwalker mentioned this issue Dec 28, 2018
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Jan 4, 2019
@lukedirtwalker
PS: Handle ISD-local AS-wildcard seg requests
ca54037 
Fixes scionproto#2281
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Jan 4, 2019
@lukedirtwalker
PS: Handle ISD-local AS-wildcard seg requests
af90342 
Fixes scionproto#2281
lukedirtwalker added a commit that referenced this issue Jan 4, 2019
@lukedirtwalker
PS: Handle ISD-local AS-wildcard seg requests (#2284)
f66a8ff 
Fixes #2281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukedirtwalker