Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel: modified licenses.tar file after running acceptance test #2576

Closed
sgmonroy opened this issue Apr 3, 2019 · 4 comments
Closed

Bazel: modified licenses.tar file after running acceptance test #2576

sgmonroy opened this issue Apr 3, 2019 · 4 comments
Assignees

Comments

@sgmonroy
Copy link
Contributor

sgmonroy commented Apr 3, 2019

When running acceptance tests on Master, the following files are modified:
docker/perapp/licenses.tar

Current Master commit hash:
commit 9a8e66f

@worxli
Copy link
Contributor

worxli commented May 9, 2019

More precisely the file is modified when running make -C docker/perapp.

@worxli worxli closed this as completed May 9, 2019
@kormat
Copy link
Contributor

kormat commented Jun 18, 2019

This problem still exists, reopening.

@kormat kormat reopened this Jun 18, 2019
@kormat
Copy link
Contributor

kormat commented Jun 20, 2019

From an off-line discussion with @sustrik:

  • Python packages from pip come with their own licenses.
  • Apt packages put their licesnses into /usr/share/doc/, and docker/perapp/files/copy_package already handles this

So the remaining thing we need to care about is licenses from go libraries we depend on.

Proposed fix:

  • Add a go_deps target to the top-level Makefile. It should run tools/fetch.sh if WORKSPACE has changed, and generate a BUILD.bzl file containing a target that depends on all go dependencies.
  • Convert docker/perapp/licenses.tar into a bazel target, that depends on the target generated by tools/fetch.sh
  • Have all docker image targets depend on licenses.tar

@scrye
Copy link
Contributor

scrye commented May 4, 2020

Licensing changed in #3692, closing this as it should now be fixed.

@scrye scrye closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants