New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New system for gathering license files #3692

Merged

sustrik merged 7 commits into scionproto:master from sustrik:licenses

Mar 25, 2020

Contributor

sustrik commented Mar 24, 2020 •

edited by kormat

Loading

This change is

sustrik requested a review from scrye

March 24, 2020 07:59

scrye suggested changes

View reviewed changes

Contributor

scrye left a comment

Reviewed 183 of 183 files at r1.
Reviewable status: all files reviewed, 14 unresolved discussions (waiting on @sustrik)

licenses/data/com_github_prometheus_procfs/scripts/check_license.sh, line 1 at r1 (raw file):

#!/bin/sh

We should skip this file.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_agpl.go, line 1 at r1 (raw file):

package cmd

This is not the license of the package (which is Apache 2.0), but rather library support for licensing. It should not be included.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_apache_2.go, line 1 at r1 (raw file):

// Copyright © 2015 Steve Francia <spf@spf13.com>.

Same as above.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_bsd_clause_2.go, line 1 at r1 (raw file):

// Copyright © 2015 Steve Francia <spf@spf13.com>.

Same as above.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_bsd_clause_3.go, line 1 at r1 (raw file):

// Copyright © 2015 Steve Francia <spf@spf13.com>.

Same as above.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_gpl_2.go, line 1 at r1 (raw file):

// Copyright © 2015 Steve Francia <spf@spf13.com>.

Same as above.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_gpl_3.go, line 1 at r1 (raw file):

// Copyright © 2015 Steve Francia <spf@spf13.com>.

Same as above.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_lgpl.go, line 1 at r1 (raw file):

package cmd

Same as above.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_mit.go, line 1 at r1 (raw file):

// Copyright © 2015 Steve Francia <spf@spf13.com>.

Same as above.

licenses/data/com_github_spf13_cobra/cobra/cmd/licenses.go, line 1 at r1 (raw file):

// Copyright © 2015 Steve Francia <spf@spf13.com>.

Same as above.

licenses/data/com_github_uber_jaeger_client_go/scripts/updateLicense.py, line 1 at r1 (raw file):

from __future__ import (

Again, this looks like library support.

licenses/data/com_github_uber_jaeger_client_go/scripts/updateLicenses.sh, line 1 at r1 (raw file):

#!/bin/bash

This looks like license retrieval support.

licenses/data/com_github_uber_jaeger_lib/scripts/updateLicense.py, line 1 at r1 (raw file):

from __future__ import (

This looks like license retrieval support.

licenses/data/com_github_uber_jaeger_lib/scripts/updateLicenses.sh, line 1 at r1 (raw file):

#!/bin/bash

This looks like license retrieval support.

sustrik commented

View reviewed changes

Contributor Author

sustrik left a comment

Reviewable status: all files reviewed, 14 unresolved discussions (waiting on @scrye)

licenses/data/com_github_prometheus_procfs/scripts/check_license.sh, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

We should skip this file.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_agpl.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

This is not the license of the package (which is Apache 2.0), but rather library support for licensing. It should not be included.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_apache_2.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_bsd_clause_2.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_bsd_clause_3.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_gpl_2.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_gpl_3.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_lgpl.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/license_mit.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_spf13_cobra/cobra/cmd/licenses.go, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Same as above.

Done.

licenses/data/com_github_uber_jaeger_client_go/scripts/updateLicense.py, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Again, this looks like library support.

Done.

licenses/data/com_github_uber_jaeger_client_go/scripts/updateLicenses.sh, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

This looks like license retrieval support.

Done.

licenses/data/com_github_uber_jaeger_lib/scripts/updateLicense.py, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

This looks like license retrieval support.

Done.

licenses/data/com_github_uber_jaeger_lib/scripts/updateLicenses.sh, line 1 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

This looks like license retrieval support.

Done.

scrye approved these changes

View reviewed changes

Contributor

scrye left a comment

Reviewed 16 of 26 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

sustrik added 7 commits

March 25, 2020 12:35


          New system for gathering license files

b616c28


          fix linter

b8806d2


          fix linter in a more clean way

98ada68


          Remove non-licenses

21e30dc


          CI checks licenses

658eab5

fix

ddd0f42


          remove leftover

dbb4b86

sustrik merged commit b0555ea into scionproto:master

sustrik deleted the licenses branch

March 25, 2020 11:53

stygerma pushed a commit to stygerma/scion that referenced this pull request


          New system for gathering license files (scionproto#3692)

77cee4b

stygerma pushed a commit to stygerma/scion that referenced this pull request


          New system for gathering license files (scionproto#3692)

8140e1f

stygerma pushed a commit to stygerma/scion that referenced this pull request


          New system for gathering license files (scionproto#3692)

411f66d

scrye mentioned this pull request

Bazel: modified licenses.tar file after running acceptance test #2576

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet