Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate db tests away from goconvey #2986

Closed
lukedirtwalker opened this issue Aug 13, 2019 · 2 comments
Closed

Migrate db tests away from goconvey #2986

lukedirtwalker opened this issue Aug 13, 2019 · 2 comments
Assignees
@lukedirtwalker
Labels
i/good first issue Good for newcomers refactor Change that focuses around reducing tech debt

Comments

@lukedirtwalker
Copy link
Collaborator

path, trust, and beacon db should no longer use goconvey. With it the output from CI is not detailed enough to properly analyze why a test failed.

We generally want to migrate away from goconvey, to standard go tests with assert libs.
@lukedirtwalker lukedirtwalker self-assigned this Aug 13, 2019
@lukedirtwalker lukedirtwalker mentioned this issue Aug 13, 2019
Merged
lukedirtwalker added a commit that referenced this issue Aug 13, 2019
@lukedirtwalker
Remove goconvey from {pathdb,periodic,util} tests (#2988)
c2a11de 
Remove goconvey from
-pathdb
-periodic
-util
tests.

Without convey we have better insights into failures that happen in CI.

Contributes #2986
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Aug 21, 2019
@lukedirtwalker
Replace more goconvey tests with normal tests
a88d7a4 
beacondb test suite
beacondb/sqlite
pathdb/sqlite
part of scion-pki

Contributes scionproto#2986
@lukedirtwalker lukedirtwalker mentioned this issue Aug 21, 2019
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Aug 21, 2019
@lukedirtwalker
Replace more goconvey tests with normal tests
b79fd51 
beacondb test suite
beacondb/sqlite
pathdb/sqlite
part of scion-pki

Contributes scionproto#2986
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Aug 21, 2019
@lukedirtwalker
Replace more goconvey tests with normal tests
7aa6784 
beacondb test suite
beacondb/sqlite
pathdb/sqlite
part of scion-pki

Contributes scionproto#2986
lukedirtwalker added a commit that referenced this issue Aug 21, 2019
@lukedirtwalker
Replace more goconvey tests with normal tests (#3020)
b8062c0 
beacondb test suite
beacondb/sqlite
pathdb/sqlite
part of scion-pki

Contributes #2986
@lukedirtwalker lukedirtwalker added the refactor Change that focuses around reducing tech debt label Sep 4, 2019
@scrye scrye added the i/good first issue Good for newcomers label Sep 4, 2019
@scrye
Copy link
Contributor

scrye commented Nov 1, 2019 •
edited
Loading

As I understand it, there's only go/lib/revcache/revcachetest and go/lib/infra/modules/trust/trustdb/trustdbtest left.

@scrye scrye modified the milestone: S01 E01 Jan 7, 2020
@scrye scrye added i/good first issue Good for newcomers i/help wanted Nobody is working on this at the moment and removed i/good first issue Good for newcomers i/help wanted Nobody is working on this at the moment labels May 4, 2020
@matzf
Copy link
Contributor

matzf commented May 27, 2022

None of the db tests use goconvey anymore. Keeping the more generic issue #3016 open seems sufficient to keep track of removing the remaining occurrences.

@matzf matzf closed this as completed May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
i/good first issue Good for newcomers refactor Change that focuses around reducing tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lukedirtwalker @scrye @matzf