SIG: Avoid using path removed from path pool

[oncilla]

Reset the path for the worker immediately if the current path is no longer part of the path set.

---

This change is 

[kormat]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)

---

go/sig/egress/session/sessmon.go, line 146 at r1 (raw file):

			currSessPath = sm.getNewPath(nil)
			sm.needUpdate = true
			// Traffic must no longer be sent on the old path.

I'd expand this comment a bit, and mention that this implies that encap traffic will be sent on an un-tested path, but that it will get handled later, etc.

---

go/sig/egress/worker/worker.go, line 216 at r1 (raw file):

			w.currPathEntry = remote.SessPath.PathEntry()
		} else {
			w.currPathEntry = nil

This could be simplified to:

w.currPathEntry = nil
if remote.SessPath != nil {
	w.currPathEntry = remote.SessPath.PathEntry()
}

[oncilla]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @kormat)

---

go/sig/egress/session/sessmon.go, line 146 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

I'd expand this comment a bit, and mention that this implies that encap traffic will be sent on an un-tested path, but that it will get handled later, etc.

Done.

---

go/sig/egress/worker/worker.go, line 216 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

This could be simplified to:

w.currPathEntry = nil
if remote.SessPath != nil {
	w.currPathEntry = remote.SessPath.PathEntry()
}

Done.

[kormat]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved