Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: Create duration wrapper #1963

Merged
merged 3 commits into from
Oct 11, 2018
Merged

lib: Create duration wrapper #1963

merged 3 commits into from
Oct 11, 2018

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Oct 10, 2018

fixes #1961


This change is Reviewable

@oncilla oncilla changed the title lib: Move duration to env lib: Create duration wrapper Oct 10, 2018
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit c0735fe into scionproto:master Oct 11, 2018
@oncilla oncilla deleted the go-lib-dur branch October 11, 2018 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lib: duration wrapper in util
3 participants