spkt: check for minimum common header length

[sgmonroy]

This change is 

[kormat]

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sgmonroy)

---

go/lib/spkt/cmnhdr.go, line 56 at r1 (raw file):

	// Check for minimum header length
	if len(b) < CmnHdrLen {
		return common.NewBasicError("Packet is too small", nil, "Size", len(b))

I'd be a bit more specific, and also not assume this is from a packet: "Can't parse common header, buffer is too short"

We also generally use lower-case for the logging keys ("size" rather than "size"), and use len rather than size.

[sgmonroy]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @kormat)

---

go/lib/spkt/cmnhdr.go, line 56 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

I'd be a bit more specific, and also not assume this is from a packet: "Can't parse common header, buffer is too short"

We also generally use lower-case for the logging keys ("size" rather than "size"), and use len rather than size.

Done.

[kormat]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved