Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce raciness in test #1996

Merged
merged 1 commit into from
Oct 18, 2018
Merged

Reduce raciness in test #1996

merged 1 commit into from
Oct 18, 2018

Commits on Oct 18, 2018

  1. Reduce raciness in test 

    fetchSegsFromDBRetry select on ctx.Done() and time.After().
If the setup/calling of ctx.Done() takes more than what we pass in time.After,
it can be that both channels are ready at the same time and then the test might fail.

By increasing the timeout in the test this should no longer be a problem.
    @lukedirtwalker
    lukedirtwalker committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    edc2d12 View commit details
    Browse the repository at this point in the history