gen: Refactor generator #2059
Merged
gen: Refactor generator #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrye
suggested changes
Oct 29, 2018
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on @scrye and @worxli)
a discussion (no related file):
Code looks good, doing a little bit of testing now.
scrye
reviewed
Oct 29, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scrye and @worxli)
scrye
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @worxli)
Refactor `topology/generator.py` in multiple files.
scrye
approved these changes
Oct 29, 2018
There was a problem hiding this comment.
Reviewable status:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
topology/generator.pyin multiple files.This change is