log.LogPanicAndExit is callers responsibility #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrye
approved these changes
Oct 30, 2018
There was a problem hiding this comment.
Reviewed 34 of 34 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kormat)
By using the same pattern everywhere we can easily check for go routines that do not call log.LogPanicAndExit. Also this commit adds a few missing calls in fetcher and deduper and possibly more.
lukedirtwalker
force-pushed
the
pubLogPanic
branch
from
bb7f692
to
366be67
Compare
scrye
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
scrye
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the same pattern everywhere we can easily check for go routines that do not call log.LogPanicAndExit.
Also this commit adds a few missing calls in fetcher and deduper and possibly more.
This change is