Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PS: Push cert chain to local CS #2079

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Nov 1, 2018

Fixes #2056


This change is Reviewable

@scrye
Copy link
Contributor

scrye commented Nov 1, 2018


go/lib/infra/modules/trust/trust.go, line 356 at r1 (raw file):

}

func (store *Store) newChainValidatorForwarding(validator *trc.TRC) ValidateChainFunc {

Please add the comment specifying the limitation of this solution that we discussed offline (or reference an issue stating it).

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @shitz)

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @scrye and @shitz)


go/lib/infra/modules/trust/trust.go, line 356 at r1 (raw file):

Previously, scrye (Sergiu Costea) wrote…

Please add the comment specifying the limitation of this solution that we discussed offline (or reference an issue stating it).

Done.

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shitz)

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @shitz)

@lukedirtwalker lukedirtwalker merged commit 7e65e74 into scionproto:master Nov 2, 2018
@lukedirtwalker lukedirtwalker deleted the pubCSPush branch November 2, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants