Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fmt15 dependency. #2118

Merged
merged 1 commit into from
Nov 12, 2018
Merged

Update fmt15 dependency. #2118

merged 1 commit into from
Nov 12, 2018

Conversation

kormat
Copy link
Contributor

@kormat kormat commented Nov 12, 2018

Contains a formatting fix:
kormat/fmt15@ee69fec


This change is Reviewable

Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kormat)

a discussion (no related file):
Please also fix topo_sd_reloads_cs_acceptance/test to no longer search for quote marks.

Basically, acceptance/run reloads should not fail (I think the above is the only test with quotes).


Copy link
Contributor Author

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @scrye)

a discussion (no related file):

Previously, scrye (Sergiu Costea) wrote…

Please also fix topo_sd_reloads_cs_acceptance/test to no longer search for quote marks.

Basically, acceptance/run reloads should not fail (I think the above is the only test with quotes).

Done.


Contains a formatting fix:
kormat/fmt15@ee69fec

Also:
- Update an acceptance test that expected the quotes produced by the
  formatting bug.
- Change `scion.sh stop` not exit non-zero if one of the /dev/shm dirs
  didn't exist.
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kormat kormat merged commit 913e967 into scionproto:master Nov 12, 2018
@kormat kormat deleted the upd_fmt15 branch November 12, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants