Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with run_command and set -e in acceptance/lib.sh #2135

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Fix issue with run_command and set -e in acceptance/lib.sh #2135

merged 1 commit into from
Nov 16, 2018

Conversation

kormat
Copy link
Contributor

@kormat kormat commented Nov 16, 2018 •
edited
Loading

This change is Reviewable

scrye
scrye approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik
Copy link
Contributor

sustrik commented Nov 16, 2018

LGTM

@sustrik
Copy link
Contributor

sustrik commented Nov 16, 2018

:lgtm:

@kormat kormat merged commit c2cd5b6 into scionproto:master Nov 16, 2018
@kormat kormat deleted the acc_run_fix branch November 16, 2018 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrye scrye scrye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kormat @sustrik @scrye