-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --docker-registry and --image-tag flags to generator #2160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)
python/topology/docker.py, line 357 at r1 (raw file):
] def _docker_image(self, image):
How about putting this in common.py
, and change it to docker_image(args, image)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @kormat)
python/topology/docker.py, line 357 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
How about putting this in
common.py
, and change it todocker_image(args, image)
?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @worxli)
docker/perapp/publish, line 10 at r3 (raw file):
# Tag local apps and push to remote for app in border dispatcher sig cert path sciond beacon_py cert_py path_py sciond_py; do
I would order this by service type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 12 of 13 files reviewed, 1 unresolved discussion (waiting on @kormat)
docker/perapp/publish, line 10 at r3 (raw file):
Previously, kormat (Stephen Shirley) wrote…
I would order this by service type.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved
This allows to run the dockerized topology without building docker images locally.
E.g.
./scion.sh topology -d --docker-registry scionproto --image-tag v0.x.x
This change is