-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a QuicConfig to squic Dial/Listen methods #2180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @chaehni)
go/lib/snet/squic/squic.go, line 76 at r1 (raw file):
func ListenSCIONWithBindSVC(network *snet.SCIONNetwork, laddr, baddr *snet.Addr, svc addr.HostSVC, quicConfig *quic.Config) (quic.Listener, error) { if len(srvTlsCfg.Certificates) == 0 {
Please leave a blank line after 2 lined function declarations (see https://github.com/scionproto/scion/wiki/Coding-Guidelines#function-declaration-over-multiple-lines), also in the other methods in this file. Some of them were actually wrong before, It would be great if you could change those as well. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adapted the formatting according to the guidelines.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/lib/snet/squic/squic.go, line 76 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Please leave a blank line after 2 lined function declarations (see https://github.com/scionproto/scion/wiki/Coding-Guidelines#function-declaration-over-multiple-lines), also in the other methods in this file. Some of them were actually wrong before, It would be great if you could change those as well. Thanks.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved
This PR enables clients to pass a QuicConfig to Dial/Listen methods in the squic package.
This change is