DS: Docker network allocations #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that DS is reachable in docker topology
worxli
suggested changes
Dec 11, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @oncilla and @worxli)
python/topology/topo.py, line 198 at r1 (raw file):
def _gen_srv_entries(self, topo_id, as_conf): def reg_disp(elem_id): return "disp" + topo_id.file_fmt() if self.args.docker else elem_id
I'd prefer if this func wasn't inlined.
oncilla
commented
Dec 11, 2018
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @worxli)
python/topology/topo.py, line 198 at r1 (raw file):
Previously, worxli (Lukas Bischofberger) wrote…
I'd prefer if this func wasn't inlined.
Done.
worxli
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
worxli
approved these changes
Dec 11, 2018
There was a problem hiding this comment.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that DS is reachable in docker topology
This change is