Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug in HopPredicate serialization #2288

Merged
merged 1 commit into from
Jan 4, 2019
Merged

Fix a bug in HopPredicate serialization #2288

merged 1 commit into from
Jan 4, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Jan 4, 2019 •
edited by kormat
Loading

This patch also adds a serialization unit test.

This change is Reviewable

worxli
worxli approved these changes Jan 4, 2019
View reviewed changes
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik
Fix a bug in HopPredicate serialization
b262f8b 
This patch also adds a serialization unit test.
@sustrik sustrik merged commit 35b68d5 into scionproto:master Jan 4, 2019
@sustrik sustrik deleted the hop-pred branch January 8, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worxli worxli worxli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @worxli