Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildkite: Acceptance test timestamps #2317

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Jan 10, 2019

Add timestamps to acceptance test output to better understand their performance.


This change is Reviewable

@worxli worxli force-pushed the add-acceptance-timestamps branch 4 times, most recently from a4342d0 to 928f989 Compare January 11, 2019 09:33
@worxli worxli changed the title WIP: Buildkite: Acceptance test timestamps Buildkite: Acceptance test timestamps Jan 11, 2019
@worxli worxli force-pushed the add-acceptance-timestamps branch 4 times, most recently from 78b7776 to 08255d7 Compare January 11, 2019 13:03
Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 7 of 7 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@worxli worxli merged commit 8e9df26 into scionproto:master Jan 11, 2019
@worxli worxli deleted the add-acceptance-timestamps branch January 11, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants