Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CircleCI #2449

Merged
merged 2 commits into from
Feb 13, 2019
Merged

Remove CircleCI #2449

merged 2 commits into from
Feb 13, 2019

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Feb 13, 2019

This change is Reviewable

Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove references to Circle CI from TESTING.md

Reviewable status: 0 of 4 files reviewed, all discussions resolved

Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@worxli worxli merged commit 4554d8d into scionproto:master Feb 13, 2019
@worxli worxli deleted the remove-circleci branch February 13, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants