Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload bazel test logs #2493

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Upload bazel test logs #2493

merged 1 commit into from
Mar 6, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Mar 6, 2019

This change is Reviewable

@sustrik sustrik changed the title WIP: Upload bazel test logs Upload bazel test logs Mar 6, 2019
Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @sustrik)


scion.sh, line 237 at r1 (raw file):

print_relative_test_log_paths

what does this do?


logs/.keepme, line 0 at r1 (raw file):
why is that deleted?

Copy link
Contributor Author

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @worxli)


scion.sh, line 237 at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…
print_relative_test_log_paths

what does this do?

By default bazel prints long paths to log files (e.g. /home/sustrik/.cache/bazel...) This doesn't make sense in CI env. This option causes it to print short paths "./bazel-testlogs/go/lib/..."


logs/.keepme, line at r1 (raw file):

Previously, worxli (Lukas Bischofberger) wrote…

why is that deleted?

Done.

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit f4d647a into scionproto:master Mar 6, 2019
@sustrik sustrik deleted the upload-logs branch March 8, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants