Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save bazel and python caches out of home dir #2497

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Save bazel and python caches out of home dir #2497

merged 1 commit into from
Mar 7, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Mar 6, 2019

This decreases the size of scion image by ~1/2 GB


This change is Reviewable

Copy link
Contributor

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @sustrik)


docker/Dockerfile, line 24 at r1 (raw file):

# Restore the python dependency cache from scion_base
RUN sudo tar xf /scion/cache/python_local.tar.gz -C ~

Why is sudo required?


docker/Dockerfile.base, line 48 at r1 (raw file):

    env/pip2/deps; \
    env/pip3/deps; \
    sudo mkdir -p /scion/cache; \

Ah, i was suggesting /scioncache, i'm not sure we need a hierarchy.

I would also move this step to its own RUN, so reordering pip vs bazel doesn't break things.

Copy link
Contributor Author

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @kormat and @worxli)


docker/Dockerfile, line 24 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

Why is sudo required?

Done.


docker/Dockerfile.base, line 48 at r1 (raw file):

Previously, kormat (Stephen Shirley) wrote…

Ah, i was suggesting /scioncache, i'm not sure we need a hierarchy.

I would also move this step to its own RUN, so reordering pip vs bazel doesn't break things.

Done.

Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

This decreases the size of scion image by ~1/2 GB
@sustrik sustrik merged commit 6fd91ce into scionproto:master Mar 7, 2019
@sustrik sustrik deleted the move-bazel-cache branch March 7, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants