Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable QUIC RPC in BS Messenger #2686

Merged
merged 1 commit into from
May 15, 2019
Merged

Enable QUIC RPC in BS Messenger #2686

merged 1 commit into from
May 15, 2019

Conversation

scrye
Copy link
Contributor

@scrye scrye commented May 15, 2019

Beacons and IFStateInfo messages do not support QUIC yet.


This change is Reviewable

@scrye scrye requested a review from oncilla May 15, 2019 07:29
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @oncilla)

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Beacons and IFStateInfo messages do not support QUIC yet.
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@scrye scrye merged commit 415e66e into scionproto:master May 15, 2019
@scrye scrye deleted the pubpr-quic-bs branch May 15, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants