BS: Metrics about incoming beacons

[sustrik]

This change is 

[oncilla]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @sustrik)

a discussion (no related file):
Add commit description.

---

---

go/beacon_srv/internal/beaconing/metrics/metrics.go, line 60 at r1 (raw file):

)

// receiver holds the metrics about incoming beacons.

s/receiver/Receiver

---

go/beacon_srv/internal/beaconing/metrics/metrics.go, line 65 at r1 (raw file):

}

// Initeceiver initializes the receiver metrics and returns a handle.

s/Initeceiver/InitReceiver

---

go/beacon_srv/internal/beaconing/metrics/metrics.go, line 78 at r1 (raw file):

		totalBeacons: *prom.NewCounterVec(
			ns, "", "beacons_total", "Number of beacons received",
			[]string{"in_ifid", "result"}),

Do you think it would be useful to have the startIA in there?

[sustrik]

Reviewable status: 1 of 2 files reviewed, 4 unresolved discussions (waiting on @oncilla and @sustrik)

---

go/beacon_srv/internal/beaconing/metrics/metrics.go, line 60 at r1 (raw file):

Previously, Oncilla wrote…

s/receiver/Receiver

Done.

---

go/beacon_srv/internal/beaconing/metrics/metrics.go, line 65 at r1 (raw file):

Previously, Oncilla wrote…

s/Initeceiver/InitReceiver

Done.

---

go/beacon_srv/internal/beaconing/metrics/metrics.go, line 78 at r1 (raw file):

Previously, Oncilla wrote…

Do you think it would be useful to have the startIA in there?

Generally, I am not in favour of having startIA in metrics, because of the DoS attacks. Send enough beacons for random ASes and you'll kill prometheus.

[oncilla]

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)

[oncilla]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik)

[sustrik]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

a discussion (no related file):

Previously, Oncilla wrote…

Add commit description.

Done.

---

[oncilla]

Reviewable status: complete! all files reviewed, all discussions resolved