Move message-specific behavior out of generic RPC library

[scrye]

This change is 

[oncilla]

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @scrye)

---

go/lib/infra/messenger/quic_handler.go, line 98 at r1 (raw file):

}

func messageToSignedPayload(msg *capnp.Message) (*ctrl.SignedPld, error) {

unpacking should be protected with the following against panics.

defer func() {
	if rec := recover(); rec != nil {
		err = common.NewBasicError("pogs panic", nil, "panic", rec)
	}
}()

Should we maybe make cereal.go:parseStruct public? Since this is
essentially code duplication.

Also, there is a bug in cereal.go:parseStruct
The error should not be scoped to the if-statement, please fix while your at it.

---

go/lib/infra/messenger/quic_handler.go, line 110 at r1 (raw file):

}

func signedPldToMessage(signedPld *ctrl.SignedPld) (*capnp.Message, error) {

The spelling is not consistent.
Pld vs Payload
Proposal

messageToSignedPayload
signedPayloadToMessage

or

// favorite
msgToSignedPld
signedPldToMsg

or

signedPldFromMsg
signedPldToMsg

or

msgToSignedPld
msgFromSignedPld

---

go/lib/infra/rpc/rpc.go, line 164 at r1 (raw file):

		return nil, err
	}
	msg, err := capnp.NewDecoder(stream).Decode()

Should this be wrapped by a recover?

[scrye]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @oncilla)

---

go/lib/infra/messenger/quic_handler.go, line 98 at r1 (raw file):

Previously, Oncilla wrote…

unpacking should be protected with the following against panics.

defer func() {
	if rec := recover(); rec != nil {
		err = common.NewBasicError("pogs panic", nil, "panic", rec)
	}
}()

Should we maybe make cereal.go:parseStruct public? Since this is
essentially code duplication.

Also, there is a bug in cereal.go:parseStruct
The error should not be scoped to the if-statement, please fix while your at it.

Done.

---

go/lib/infra/messenger/quic_handler.go, line 110 at r1 (raw file):

Previously, Oncilla wrote…

The spelling is not consistent.
Pld vs Payload
Proposal

messageToSignedPayload
signedPayloadToMessage

or

// favorite
msgToSignedPld
signedPldToMsg

or

signedPldFromMsg
signedPldToMsg

or

msgToSignedPld
msgFromSignedPld

Done.

---

go/lib/infra/rpc/rpc.go, line 164 at r1 (raw file):

Previously, Oncilla wrote…

Should this be wrapped by a recover?

Done.

Unit testing this needs interfaces and mocks though, so I skipped it.

[oncilla]

Reviewed 7 of 7 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved