Accept: Refactor command structure #2710
Conversation
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla and @scrye)
acceptance/bs_add_link_acceptance/test, line 55 at r1 (raw file):
Retrun
Return
acceptance/common/README.md, line 10 at r1 (raw file):
have multiple classes
The text only explains the Test class that is needed, what else is needed?
There was a problem hiding this comment.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker and @scrye)
acceptance/bs_add_link_acceptance/test, line 55 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
RetrunReturn
Done.
acceptance/common/README.md, line 10 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
have multiple classesThe text only explains the Test class that is needed, what else is needed?
Done.
As it turns out, plumbum expects every sub-command to be their own cli.Application. This PR refactors the acceptance framework and introduces 2 base classes. One for the test definition and doc string, and one for the sub-commands.
oncilla
force-pushed
the
pub-acceptance-refactor
branch
from
09b0cee
to
16455bd
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @scrye)
As it turns out, plumbum expects every sub-command to be their
own cli.Application. This PR refactors the acceptance framework
and introduces 2 base classes. One for the test definition and
doc string, and one for the sub-commands.
This change is