Ordered topology start #2717
Merged
Ordered topology start #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR first starts the dispatcher and border routers to ensure initial connectivity. Currently, some tests fail because the beacon server are started before the border routers and the ifid keepalives are not delivered. By the time the border router has started, the interface is already revoked. The introduced ordering will avoid this problem.
lukedirtwalker
approved these changes
May 28, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR first starts the dispatcher and border routers to ensure
initial connectivity.
Currently, some tests fail because the beacon server are started
before the border routers and the ifid keepalives are not delivered.
By the time the border router has started, the interface is already
revoked. The introduced ordering will avoid this problem.
This change is