-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scion.sh traces command to view traces from a folder #2825
Add scion.sh traces command to view traces from a folder #2825
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
scion.sh, line 390 at r1 (raw file):
} cmd_traces() {
this should probably also have a stop command.
scion.sh, line 408 at r1 (raw file):
jaegertracing/all-in-one:1.12.0 sleep 3 x-www-browser "localhost:$port"
this does not work for google-chrome. Do this instead:
x-www-browser http://localhost:$port
This helps to easily view traces from a folder, it will start the jaeger all-in-one container and open the browser to view the traces. Co-authored-by: Oncilla <roos@anapaya.net>
63de99f
to
1e1610b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @oncilla)
scion.sh, line 390 at r1 (raw file):
Previously, Oncilla wrote…
this should probably also have a stop command.
Done.
scion.sh, line 408 at r1 (raw file):
Previously, Oncilla wrote…
this does not work for google-chrome. Do this instead:
x-www-browser http://localhost:$port
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
This helps to easily view traces from a folder,
it will start the jaeger all-in-one container and open the browser to view the traces.
Co-authored-by: Oncilla roos@anapaya.net
This change is