Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scion.sh traces command to view traces from a folder #2825

Merged
merged 2 commits into from
Jul 1, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Jul 1, 2019

This helps to easily view traces from a folder,
it will start the jaeger all-in-one container and open the browser to view the traces.

Co-authored-by: Oncilla roos@anapaya.net


This change is Reviewable

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)


scion.sh, line 390 at r1 (raw file):

}

cmd_traces() {

this should probably also have a stop command.


scion.sh, line 408 at r1 (raw file):

        jaegertracing/all-in-one:1.12.0
    sleep 3
    x-www-browser "localhost:$port"

this does not work for google-chrome. Do this instead:
x-www-browser http://localhost:$port

lukedirtwalker and others added 2 commits July 1, 2019 14:14
This helps to easily view traces from a folder,
it will start the jaeger all-in-one container and open the browser to view the traces.

Co-authored-by: Oncilla <roos@anapaya.net>
Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @oncilla)


scion.sh, line 390 at r1 (raw file):

Previously, Oncilla wrote…

this should probably also have a stop command.

Done.


scion.sh, line 408 at r1 (raw file):

Previously, Oncilla wrote…

this does not work for google-chrome. Do this instead:
x-www-browser http://localhost:$port

Done.

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit 6bc589a into scionproto:master Jul 1, 2019
@lukedirtwalker lukedirtwalker deleted the pubTracingRead branch July 1, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants