path lookup: Add requester #2913
Conversation
Adds a requester component that fetches segments from a remote server. Contributes scionproto#2454
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)
go/lib/infra/modules/segfetcher/requester.go, line 34 at r1 (raw file):
// DestProvider provides the destination for a segment lookup. type DestProvider interface {
We generally use dst instead of dest.
go/lib/infra/modules/segfetcher/requester.go, line 50 at r1 (raw file):
} // Request the missing segments from the remote. Note that
what should I note?
Probably that if Up or Down are non-zero, no core is fetched :)
go/lib/infra/modules/segfetcher/requester.go, line 91 at r1 (raw file):
defer close(replies) wg.Wait()
remove empty line
There was a problem hiding this comment.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @oncilla)
go/lib/infra/modules/segfetcher/requester.go, line 34 at r1 (raw file):
Previously, Oncilla wrote…
We generally use dst instead of dest.
Done.
go/lib/infra/modules/segfetcher/requester.go, line 50 at r1 (raw file):
Previously, Oncilla wrote…
what should I note?
Probably that if Up or Down are non-zero, no core is fetched :)
Yes, see it works 💯 Done.
go/lib/infra/modules/segfetcher/requester.go, line 91 at r1 (raw file):
Previously, Oncilla wrote…
remove empty line
Done.
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Adds a requester component that fetches segments from a remote server.
Contributes #2454
This change is