HP: Add HP messages to the messenger

[chaehni]

Fixes #2896

---

This change is 

[lukedirtwalker]

Reviewed 8 of 8 files at r1.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @chaehni)

---

go/lib/infra/common.go, line 204 at r1 (raw file):

	case HPSegReply:
		return "HPSegReply"
	case HPSegReg:

Those should have the same order as the definitions. So move HpSegReg up to just after Ack

---

go/lib/infra/common.go, line 265 at r1 (raw file):

	case HPSegReply:
		return "hp_seg_push"
	case HPSegReg:

ditto move up.

---

go/lib/infra/messenger/messenger.go, line 586 at r1 (raw file):

	}
	logger := log.FromCtx(ctx)
	logger.Trace("[Messenger] Sending Notify", "type", infra.SegReply, "to", a, "id", id)

HPSegReply

---

go/lib/infra/messenger/messenger.go, line 587 at r1 (raw file):

	logger := log.FromCtx(ctx)
	logger.Trace("[Messenger] Sending Notify", "type", infra.SegReply, "to", a, "id", id)
	return m.getFallbackRequester(infra.SegReply).Notify(ctx, pld, a)

HPSegReply

---

go/lib/infra/messenger/messenger.go, line 629 at r1 (raw file):

HPSegReply)

HPCfgReply

---

go/lib/sciond/sciond.go, line 186 at r1 (raw file):

				// TODO(chaehni): set HPCfgs to nil until it is clear what the client
				// API looks like to properly set this
				HPCfgs: nil,

That is not really needed it is by default nil. If you want to keep the comment I would add it to the interface. (something like: TODO(chaehni): Add way to specify HPCfgs Ids)

[chaehni]

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @lukedirtwalker)

---

go/lib/infra/common.go, line 204 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Those should have the same order as the definitions. So move HpSegReg up to just after Ack

Done.

---

go/lib/infra/common.go, line 265 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

ditto move up.

Done.

---

go/lib/infra/messenger/messenger.go, line 586 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

HPSegReply

Done.

---

go/lib/infra/messenger/messenger.go, line 587 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

HPSegReply

Done.

---

go/lib/infra/messenger/messenger.go, line 629 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

HPSegReply)

HPCfgReply

Done.

---

go/lib/sciond/sciond.go, line 186 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

That is not really needed it is by default nil. If you want to keep the comment I would add it to the interface. (something like: TODO(chaehni): Add way to specify HPCfgs Ids)

You're right. I added it to make it explicit but I guess this is not something we can forget.
Removed the comment.

[lukedirtwalker]

Reviewed 3 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved