Remove unused code

go/lib/pktcls/BUILD.bazel

@@ -3,7 +3,6 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
 go_library(
     name = "go_default_library",
     srcs = [
-        "action.go",
         "class.go",
         "cond.go",
         "doc.go",

go/lib/pktcls/doc.go

@@ -1,4 +1,5 @@
 // Copyright 2017 ETH Zurich
+// Copyright 2019 ETH Zurich, Anapaya Systems
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -12,7 +13,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// Package class implements tools for classifying and acting on network
+// Package pktcls implements tools for classifying and acting on network
 // packets.
 //
 // A class is a named condition that exposes an Eval method; when Eval yields
@@ -28,16 +29,8 @@
 // and ToS/DSCP fields match. Multiple predicates can be checked by enumerating
 // them under AllOf or AnyOf.
 //
-// Actions are marshalable objects that describe a process. Currently, the only
-// supported actions are Path Filters (ActionFilterPaths), which are containers
-// for a spathmeta.PathPredicate object.
-//
-// Marshalable policies can be implemented by external code by mapping Cond
-// items to Action items.
-//
-// Package class supports JSON marshaling and unmarshaling of classes and
-// actions.  Due to the custom formatting of the JSON output, marshaling must
-// be done by first adding the classes and actions to a ClassMap or ActionMap,
-// respectively. Unmarshaling back to the Map is guaranteed to yield an object
-// that is identical to the initial one.
+// The package contains support for JSON marshaling and unmarshaling of
+// classes. Due to the custom formatting of the JSON output, marshaling must be
+// done by first adding the classes to a ClassMap. Unmarshaling back to the Map
+// is guaranteed to yield an object that is identical to the initial one.
 package pktcls

go/lib/pktcls/json.go

@@ -131,19 +131,6 @@ func unmarshalCond(b []byte) (Cond, error) {
 	return c, nil
 }
 
-// unmarshalAction extracts an Action from a JSON encoding
-func unmarshalAction(b []byte) (Action, error) {
-	t, err := unmarshalInterface(b)
-	if err != nil {
-		return nil, err
-	}
-	a, ok := t.(Action)
-	if !ok {
-		return nil, common.NewBasicError("Unable to extract Cond from interface", nil)
-	}
-	return a, nil
-}
-
 // unmarshal extracts an IPv4Predicate from a JSON encoding
 func unmarshalPredicate(b []byte) (IPv4Predicate, error) {
 	t, err := unmarshalInterface(b)

go/lib/spath/spathmeta/BUILD.bazel

@@ -1,28 +1,12 @@
-load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
+load("@io_bazel_rules_go//go:def.bzl", "go_library")
 
 go_library(
     name = "go_default_library",
-    srcs = [
-        "apppath.go",
-        "pred.go",
-    ],
+    srcs = ["apppath.go"],
     importpath = "github.com/scionproto/scion/go/lib/spath/spathmeta",
     visibility = ["//visibility:public"],
     deps = [
         "//go/lib/common:go_default_library",
         "//go/lib/sciond:go_default_library",
     ],
 )
-
-go_test(
-    name = "go_default_test",
-    srcs = ["pred_test.go"],
-    embed = [":go_default_library"],
-    deps = [
-        "//go/lib/addr:go_default_library",
-        "//go/lib/sciond:go_default_library",
-        "//go/lib/xtest/graph:go_default_library",
-        "@com_github_golang_mock//gomock:go_default_library",
-        "@com_github_smartystreets_goconvey//convey:go_default_library",
-    ],
-)