pathdb: Change GetNextQuery to include src and policy #2956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For scionproto#2454 we need to include src in the NextQuery table. For policies in path lookups we need policy. Note that existing deployments need to update the database, this is best done by nuking the NextQuery table and create it fresh. Migration instructions: Upgrade sqlite DB: `sqlite3 gen-cache/sd1-ff00_0_111.path.db < go/lib/pathdb/sqlite/migrate_7_8.up.sql` Contributes scionproto#2454
oncilla
approved these changes
Aug 6, 2019
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
kormat
added
the
i/breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2454 we need to include src in the NextQuery table.
For policies in path lookups we need policy.
Note that existing deployments need to update the database, this is best done by nuking the NextQuery table and create it fresh.
Migration instructions:
Upgrade sqlite DB:
sqlite3 gen-cache/sd1-ff00_0_111.path.db < go/lib/pathdb/sqlite/migrate_7_8.up.sqlContributes #2454
This change is