Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BR: remove netconf package #2966

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Conversation

sgmonroy
Copy link
Contributor

@sgmonroy sgmonroy commented Aug 7, 2019

Remove the border/netconf package and instead modify the topology with
the useful meta information such as the map of owned interfaces per BR.

Also add the key to both the BRInfo and IFInfo such that when references
are passed around, it is stright forward to know the BR name and
interface ID respectively.


This change is Reviewable

@oncilla oncilla self-requested a review August 7, 2019 11:29
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 18 of 18 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Remove the border/netconf package and instead modify the topology with
the useful meta information such as the map of owned interfaces per BR.

Also add the key to both the BRInfo and IFInfo such that when references
are passed around, it is stright forward to know the BR name and
interface ID respectively.
@sgmonroy sgmonroy merged commit 434510d into scionproto:master Aug 7, 2019
@sgmonroy sgmonroy deleted the br-rm-netconf branch August 7, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants