scrypto: Fix flaky tests

[oncilla]

Always provide the not_before time of the validity period to avoid
flaky tests at second boundaries.

fixes #2993

---

This change is 

[lukedirtwalker]

Reviewed 13 of 13 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

---

go/lib/scrypto/cert/v2/base_test.go, line 85 at r1 (raw file):

func newBaseCert(notBefore time.Time) cert.Base {
	now := notBefore.Round(time.Second)

Maybe -1 so that if you have tests that do checks with the not before and now they will actually work as expected (Round rounds up so Now() could suddenly be before not_before which is a bit counter intuitive) That comment applies to all locations you do this.

[oncilla]

Reviewable status: 11 of 13 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)

---

go/lib/scrypto/cert/v2/base_test.go, line 85 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Maybe -1 so that if you have tests that do checks with the not before and now they will actually work as expected (Round rounds up so Now() could suddenly be before not_before which is a bit counter intuitive) That comment applies to all locations you do this.

Ah yeah, it rounds to the nearest multiple of d.
Replaced with Truncate which always rounds down.

[lukedirtwalker]

Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved