Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR acceptance: custom parameters #3203

Merged
merged 1 commit into from
Oct 1, 2019
Merged

BR acceptance: custom parameters #3203

merged 1 commit into from
Oct 1, 2019

Conversation

sgmonroy
Copy link
Contributor

@sgmonroy sgmonroy commented Sep 30, 2019 •
edited by kormat
Loading

This change is Reviewable

@sgmonroy sgmonroy requested a review from sustrik October 1, 2019 12:06
sustrik
sustrik approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

sustrik
sustrik approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@sustrik sustrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sgmonroy sgmonroy merged commit 7a26490 into scionproto:master Oct 1, 2019
@sgmonroy sgmonroy deleted the pub-br-acceptance branch October 1, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sustrik sustrik sustrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgmonroy @sustrik