Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: https clone, not recursive #3205

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Oct 1, 2019

Using --recursive and SSH no longer necessary when cloning because there are no more submodules.
Instruct to use https, because it's simpler -- no instructions about .insteadOf necessary.


This change is Reviewable

Using --recursive and SSH no longer necessary when cloning because there
are no more submodules.
Use https, because it's simpler.
Copy link
Contributor

@kormat kormat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@kormat kormat merged commit 0b03818 into scionproto:master Oct 1, 2019
@matzf matzf deleted the readme-remove-insteadOf branch October 1, 2019 09:38
matzf added a commit to netsec-ethz/scion that referenced this pull request Oct 21, 2019
Using --recursive and SSH no longer necessary when cloning because there
are no more submodules.
Use https, because it's simpler.

Manually resolved conflict: use clone netsec-ethz/netsec-scion, not scionproto/scion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants