scrypto: Make LatestVer of type version #3206
Conversation
There was a problem hiding this comment.
Reviewed 39 of 39 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)
go/lib/ctrl/signed_util.go, line 58 at r1 (raw file):
func NewSignSrcDefFromRaw(b common.RawBytes) (SignSrcDef, error) { s := reSrcDefault.FindSubmatch(b)
When the type of s changes from []string to [][]byte, renaming the var is probably good for sanity too.
go/lib/infra/modules/trust/trustdb/trustdbsqlite/db.go, line 677 at r1 (raw file):
func parseCert(raw common.RawBytes, ia addr.IA, version scrypto.Version, err error) (*cert.Certificate, error) {
Add blank line.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @kormat)
go/lib/ctrl/signed_util.go, line 58 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
When the type of
schanges from[]stringto[][]byte, renaming the var is probably good for sanity too.
s for submatch :)
go/lib/infra/modules/trust/trustdb/trustdbsqlite/db.go, line 677 at r1 (raw file):
Previously, kormat (Stephen Shirley) wrote…
Add blank line.
Done.
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
force-pushed
the
pub-scrypto-version
branch
from
d27ffb0
to
da3708b
Compare
fixes #2953
This change is