Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snet: SCIONPacketConn.ReadFrom - Don't fail on nil argument #3282

Merged
merged 1 commit into from
Oct 28, 2019
Merged

snet: SCIONPacketConn.ReadFrom - Don't fail on nil argument #3282

merged 1 commit into from
Oct 28, 2019

Conversation

sustrik
Copy link
Contributor

@sustrik sustrik commented Oct 25, 2019 •
edited by kormat
Loading

This change is Reviewable

@sustrik sustrik requested review from sgmonroy and scrye and removed request for sgmonroy October 25, 2019 14:17
scrye
scrye approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@scrye scrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@sustrik sustrik merged commit 622b3b2 into scionproto:master Oct 28, 2019
@sustrik sustrik deleted the snet branch November 7, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrye scrye scrye approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sustrik @scrye